Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrmoptions: add element-height alias for eh #1127

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

jaki
Copy link
Contributor

@jaki jaki commented May 15, 2020

When looking through other people's Rofi configuration, one might
stumble upon the option eh. It's hard to tell what it does at first
glance, unlike other options. Create an alias element-height for eh
that is more understandable. Hopefully, people start adopting this in
their config files for readability.

jaki added 2 commits May 14, 2020 22:50
When looking through other people's Rofi configuration, one might
stumble upon the option `eh`.  It's hard to tell what it does, and it is
not found in the man pages.  Create an alias `element-height` for `eh`
that is more understandable.  Hopefully, people start adopting this in
their config files for readability.

EDIT: it has been added to the documentation recently, commits
5b8aeba and
aa07b8e.
@DaveDavenport
Copy link
Collaborator

DaveDavenport commented May 15, 2020

I have a strong dislike to this option and how it is implemented. Instead of adding an alias, I want to fix this right at some point.
IMHO it should be a theme option set on a textbox, in this case

element-text {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants